This repository has been archived by the owner on Feb 1, 2023. It is now read-only.
Bitswap Refactor #2: Extract PeerManager From Want Manager + Unit Test #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
hannahhoward
force-pushed
the
feat/extract-to-package
branch
from
4d5134c
to
69d063b
Compare
hannahhoward
force-pushed
the
feat/extract-managers
branch
from
c320f0a
to
03f4615
Compare
whyrusleeping
approved these changes
Dec 5, 2018
lanzafame
reviewed
Dec 6, 2018
| NewMessageSender(context.Context, peer.ID) (bsnet.MessageSender, error) | ||
| } | ||
|
|
||
| // MessageQueue implements queuee of want messages to send to peers |
lanzafame
reviewed
Dec 6, 2018
| @@ -30,7 +38,8 @@ type MessageQueue struct { | |||
| done chan struct{} | |||
| } | |||
|
|
|||
| func New(p peer.ID, network bsnet.BitSwapNetwork) *MessageQueue { | |||
| // New creats a new MessageQueues | |||
There was a problem hiding this comment.
nitpick FYI: comments should end with a fullstop, see here, please don't feel it necessary to update all the comments but moving forward it would be great to standardize on this.
There was a problem hiding this comment.
yea I can commit to this one going forward. :)
There was a problem hiding this comment.
went ahead and implemented this across bitswap as best I could, but put this in a seperate commit (including spelling change above) to be merged right after, so as to avoid making review harder. #31
There was a problem hiding this comment.
@lanzafame is your review a ✔️ given changes in #31?
Stebalien
force-pushed
the
feat/extract-managers
branch
from
99e83c7
to
03f4615
Compare
michaelavila
approved these changes
Dec 11, 2018
|
I'm gonna go head and merge after a quick rebase. |
Seperates the functions of tracking wants from tracking peers Unit tests for both peer manager and want manager Refactor internals of both to address synchonization issues discovered in tests
Finishing adding comments to WantManager and PeerManager, refactor message structure for type safety, add sending messages test
hannahhoward
force-pushed
the
feat/extract-managers
branch
from
03f4615
to
ac45ed0
Compare
Jorropo
pushed a commit
to Jorropo/go-libipfs
that referenced
this pull request
Jan 26, 2023
Bitswap Refactor ipfs#2: Extract PeerManager From Want Manager + Unit Test This commit was moved from ipfs/go-bitswap@e9b80b6
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Modularize Bitswap in preparation for attempts to optimize bitswap further
child of #26
Implementation