This repository has been archived by the owner on Feb 1, 2023. It is now read-only.
feat(engine): tag peers with requests #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tag peers in connection manager as they have outstanding requests for blocks to serve fix #114
Jorropo
pushed a commit
to Jorropo/go-libipfs
that referenced
this pull request
Jan 26, 2023
…requests feat(engine): tag peers with requests This commit was moved from ipfs/go-bitswap@acc22c2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
fix #114 - tag peers in connection manager as they have outstanding requests for blocks to serve
Implementation
Also see ipfs/go-peertaskqueue#3 as it supports functionality here.
Essentially:
Note: Uses arbitrary weight for the time being -- not sure if there is a better solution here