This repository has been archived by the owner on Feb 1, 2023. It is now read-only.
fix(network): add mutex to avoid data race #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
approved these changes
May 20, 2019
network/ipfs_impl.go
Outdated
| @@ -172,18 +176,26 @@ func (bsnet *impl) Provide(ctx context.Context, k cid.Cid) error { | |||
| func (bsnet *impl) handleNewStream(s inet.Stream) { | |||
| defer s.Close() | |||
|
|
|||
| bsnet.receiverLk.RLock() | |||
There was a problem hiding this comment.
Let's just stash a copy of the receiver here. That way we don't have to keep re-locking (it shouldn't change, right?).
There was a problem hiding this comment.
that makes sense
|
Maybe calling SetDelegate actually it was binds the host and starts receiving messages? It is called at the very end of the BS setup already |
|
SGTM. |
delay binding of network until a receiver is present. also add test of ipfs host network
hannahhoward
force-pushed
the
fix/race-125
branch
from
916eb69 to
f67349e
Compare
|
@Stebalien re-implemented as suggested. I don't exactly know how to verify this is the right solution thought I did write a test and a cursory search shows most bitswap clients (cluster, ipfs, filecoin) initialize Bitswap shortly after initializing the network. |
|
This looks correct. |
|
And thanks for writing a test! You're setting a good example for the rest of us. |
Jorropo
pushed a commit
to Jorropo/go-libipfs
that referenced
this pull request
Jan 26, 2023
fix(network): add mutex to avoid data race This commit was moved from ipfs/go-bitswap@e546588
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Fix #125
Implementation
Adds a mutex to the network interface default implementation's receiver member. This appears to be the source of the data races in #125. While it's not totally clear if this covers all of the race conditions, it clearly something that should happen, since receiver is referenced repeatedly across multiple goroutines. Also adds a nil check to the notification methods.