fix(decision): cleanup request queues

[hannahhoward]

Goals

Remove memory leak by making sure when request queues are idle that they are removed
fix #112

Implementation

Unfortunately, cause the peer request queue uses a PriorityQueue which only has a Pop method (and no Remove method) the only point you can remove a partner is the moment it's already popped off the priority queue before you put it back on. This adds code to check and remove the partner. Also since partners do not have a peer ID you have to do an O(N) search through the list of active partners to find the peer ID -- I don't forsee this happening so much that it's necessary to improve but it could be added.

Also adds a test to make sure it happens

For discussion

• Is this the memory leak you're thinking of in Queue Memory Leak #112?
• Does this approach make sense?
• Does the remove need to be optimized by adding the peer id to the activepartner struct?

[Stebalien]

We should totally add the peer ID to the activePartner struct. Disregarding performance, it'll probably just make things simpler.

[Stebalien]

Otherwise, LGTM.

[hannahhoward]

@Stebalien added the peer ID -- going to merge later today unless I hear otherwise.

[Stebalien]

Thanks!