This repository has been archived by the owner on Feb 1, 2023. It is now read-only.
connmgr: give peers more weight when actively participating in a session #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
hannahhoward
suggested changes
Apr 29, 2019
| @@ -131,7 +133,7 @@ func (spm *SessionPeerManager) run(ctx context.Context) { | |||
| } | |||
| } | |||
|
|
|||
| func (spm *SessionPeerManager) tagPeer(p peer.ID) { | |||
| func (spm *SessionPeerManager) tagPeer(p peer.ID, value int) { | |||
| spm.tagger.TagPeer(p, spm.tag, 10) | |||
There was a problem hiding this comment.
You don't appear to be using the value passed in here
Stebalien
force-pushed
the
feat/improve-connmgr
branch
from
244ea4f to
8d74ae2
Compare
|
@hannahhoward thanks for catching that! Fixed. |
hannahhoward
approved these changes
Apr 30, 2019
Jorropo
pushed a commit
to Jorropo/go-libipfs
that referenced
this pull request
Jan 26, 2023
connmgr: give peers more weight when actively participating in a session This commit was moved from ipfs/go-bitswap@07ec9e8
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review as individual commits, the other two commits are chores.