Migration 7-8 - Encoding key filenames with base32 #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AuHau
changed the title
License: MIT Signed-off-by: Adam Uhlir <[email protected]>
AuHau
force-pushed
the
migration/8-base32_encoded_keys
branch
from
7e51bf4 to
6c6688c
Compare
AuHau
commented
Feb 22, 2019
AuHau
commented
Mar 18, 2019
| @@ -44,7 +44,8 @@ ipfs repo version | go-ipfs versions | |||
| 4 | 0.4.3 - 0.4.5 | |||
| 5 | 0.4.6 - 0.4.10 | |||
| 6 | 0.4.11 - 0.4.15 | |||
| 7 | 0.4.16 - current | |||
| 7 | 0.4.16 - 0.4.19 | |||
| 8 | 0.4.20 - current | |||
There was a problem hiding this comment.
Depends if ipfs/kubo#6012 will make it to 0.4.20 release.
Open
|
Not sure why this adds the base32 package directly here? |
|
Well I followed https://github.com/ipfs/fs-repo-migrations#dependencies and examples of other migrations. Is there a better approach in your mind? |
ah, ok. Yeah, should be vendored in its own folder at least. No worries, I'll take care. |
|
Moving to #96 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.