Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add amending-commits.md #34

Merged
merged 2 commits into from
Jun 23, 2015
Merged

Add amending-commits.md #34

merged 2 commits into from
Jun 23, 2015

Conversation

chriscool
Copy link
Contributor

This could help people improve their commits after tests or code reviews complain about them.

@jbenet jbenet added the status/in-progress In progress label Jun 16, 2015
It will open an instruction sheet in your editor where you can specify
how commits should be rebased. There you just need to replace the
"pick" instruction at the beginning of some lines with "r" (or
"reword").
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe show an example, or something:


"reword"). For example:

r 06f6e99 merkledag spec
pick 02b20bf records spec

@jbenet
Copy link
Member

jbenet commented Jun 16, 2015

@chriscool this is very good +1. couple of comments, otherwise LGTM

@wking
Copy link

wking commented Jun 18, 2015

Similar external-to-IPFS docs that we may want to consider pointing to
instead:

  • The maintained-in-git.git guide 1.
  • The embedded-in-git-scm.com book 2.

License: MIT
Signed-off-by: Christian Couder <[email protected]>
@jbenet jbenet mentioned this pull request Jun 22, 2015
55 tasks
jbenet added a commit that referenced this pull request Jun 23, 2015
@jbenet jbenet merged commit dae59f5 into master Jun 23, 2015
@jbenet jbenet removed the status/in-progress In progress label Jun 23, 2015
@jbenet
Copy link
Member

jbenet commented Jun 23, 2015

thanks @chriscool !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants