-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repository creation and readme conformity guidelines #45
Comments
Also:
Some of these should be mentioned both in the README standard requirements, and as part of a "setup a new repo" section. The setup section should include linking to https://github.com/ipfs/ipfs/blob/master/project-directory.md. |
👍 x 💯 ^ 💯 this is great. @RichardLitt we should turn this into a script we can run that uses tap/tape to check all the repos and returns an error if they're failed. we can then put that on a throwaway repo with travis-ci and we can rerun the travis build / push a commit to run tests that check all the repos are good :D |
cc @diasdavid as he cares about this too |
for the buttons, maybe we can make lists of buttons to include:
and we should have an "IPFS Project" banner.
|
YES, thank you :D @jbenet can we have like a full readme wide length 'contribute to IPFS'? The 'contribute to IPFS' section could also have an 'endeavours' section like : libp2p, go-ipfs, offline web components, starship, etc. So that people had a clear way to understand all of the things we are doing and which they might want the most to contribute :) |
Happy to turn this into a script. I guess I'll start a new repository to do that. I'm sorry, but if by "more professional" you mean more likely to be used by these people: Then I am OK with something else, otherwise that banner is already perfect. I don't think we need a Readme-width one, those are arbitrary based on window sizes anyway. Buttons to include: All reposLanguage-specific repositoriesCommunity / Docs / Discussion repos
|
Good point. Let's stick with blue. Editing comment. |
@jbenet I am a huge fan of that contribute to ipfs badge! Professionalism is boring :) |
Note: We also need to include a section for how to make community repositories. |
THe contribute to ipfs banner should link to a short doc on how to help, with links to more areas |
Is this done as something we can follow now? @RichardLitt ? |
@diasdavid No. Working on it; not sure how to best parse READMEs, I've been looking for tools that should enable us to do this well. Ongoing work will be done here: https://github.com/ipfs/ipfs-readme-standard |
Another thing to add, from @diasdavid:
|
Related: ipfs/infra#25 Ideally, IMO, we have a matrix of projects, say one project per row. Colums include:
Then you can take in the whole matrix ... If anything is not red or orange something needs help. |
We should probably also choose Travis or Circle and standardize on just one. I have switched my current preference to Travis for node projects at least. |
@harlantwood I believe we have been using both for a while because some of the times we capture different bugs in one of the two. (CI your CI :P) |
@diasdavid perhaps we standardize on "both" then? |
I would suggest to make it either or. I'm seeing the benefit of having some project use one or the other, but not having both running. |
Test infrastructure is subtly different and one will sometimes reveal problems the other does not. We've already seen this in go-ipfs. Please use both. — On Sat, Nov 7, 2015 at 5:56 PM, Friedel Ziegelmayer
|
(With testing, the more -- easy to use and working systems -- the better) — On Sat, Nov 7, 2015 at 7:51 PM, Juan Batiz-Benet [email protected] wrote:
|
Regarding the IPFS banner: I'd like to have a canonical URL and markdown fragment that is common across all repos, to make it easy to check all repos in ipfs-inactive/project-repos#1. Of course the cool thing would be to serve the image from IPFS itself: https://ipfs.io/ipfs/QmV4JU8mw3TR7kDtwkkevXm6KyQFAbSJWZKoto8NXe8iGR This works fine in a markdown image tag (which is what generates the image you see above BTW):
We could check for this exact string, and put it in every repo. But it's a lot of work to change it if the file/hash changes, so maybe it should be: [IPNS address of readme graphics]/contribute.gif Then we could furthermore (optionally) add the other badges to the same IPNS place, and serve them all from IPNS, instead of some external service. |
I suggest adding https://ci.appveyor.com/ to make everyone at least try to ensure things are working on windows as well :) |
+1 to appveyor. @harlantwood though it's much better, im not ready to rely on IPNS yet. I think we can do with the hash for now. |
we could put it in a dir, so we have a |
Would https://github.com/ipfs/community/blob/master/contributing.md be good to link to, from the Contribute banner? I'm not sure, but I can't think of a better existing document. |
Yeah https://github.com/ipfs/community/blob/master/contributing.md works for me. Let's
|
Can you PR the new ipfs/examples README to show me what you mean? I can then go about and add these to the other ones. https://github.com/ipfs/examples |
i mean put the banner + link to the root repo and project directory in the https://github.com/ipfs/community/blob/master/contributing.md doc |
@harlantwood What do you think about setting up a GitHub bot to PR repos that don't conform? I think that project-repos covers a lot of things mentioned here. We should still have a guide, though. |
@RichardLitt I think it's an awesome idea! I don't have the bandwidth to take this on myself, but would be happy to offer suggestions etc... perhaps it would want to share some code with what is now in https://github.com/ipfs/project-repos/ -- if so we could extract that common code into an npm module... |
Probably there are dedicaed github bot frameworks already, but if we were rolling our own with webhooks, I recommend https://www.npmjs.com/package/githubhook |
@harlantwood Cool. I've started over at ipfs-readme-standard. Having fun with remark/redast. We might be able to share some of the code, I've been modularizing as much as possible. |
There are a lot of good ideas about important common README components over in this Authors should also strongly consider an API section: usage examples aren't enough to fully explain a module's API. |
@noffle I've been following those threads for a while. The project seems to have stalled, so I'm going to see if I can develop something similar to what was intended. |
Also:
Should be a requirement. |
What's missing for this endeavour? |
We should have a guide for creating repositories, and for standardizing READMEs for all IPFS repositories.
Each repository should have:
What do you think are necessary? I'll open a PR after some discussion.
The text was updated successfully, but these errors were encountered: