Merge pull request ipfs/interface-go-ipfs-core#28 from ipfs/fix/dht-test

tests: fix a bunch of small test lints/issues

This commit was moved from ipfs/interface-go-ipfs-core@0d5ec37

coreiface/tests/dht.go

@@ -130,17 +130,17 @@ func (tp *provider) TestDhtProvide(t *testing.T) {
 		t.Fatal(err)
 	}
 
-	provider := <-out
+	_, ok := <-out
+
+	if ok {
+		t.Fatal("did not expect to find any providers")
+	}
 
 	self0, err := apis[0].Key().Self(ctx)
 	if err != nil {
 		t.Fatal(err)
 	}
 
-	if provider.ID.String() != "<peer.ID >" {
-		t.Errorf("got wrong provider: %s != %s", provider.ID.String(), self0.ID().String())
-	}
-
 	err = apis[0].Dht().Provide(ctx, p)
 	if err != nil {
 		t.Fatal(err)
@@ -151,7 +151,7 @@ func (tp *provider) TestDhtProvide(t *testing.T) {
 		t.Fatal(err)
 	}
 
-	provider = <-out
+	provider := <-out
 
 	if provider.ID.String() != self0.ID().String() {
 		t.Errorf("got wrong provider: %s != %s", provider.ID.String(), self0.ID().String())