-
Notifications
You must be signed in to change notification settings - Fork 11
Conversation
run the CI tests with [email protected] of note, I'm seeing test failures locally on master as well as with the latest ipfs 0.36 rc, so I'm sharing this PR to trigger CI to see if it's just an issue on my machine. License: MIT Signed-off-by: Oli Evans <[email protected]>
@alanshaw of note the tests are not passing for service-worker-gateway on 0.36.0-rc.0, but they are aren't passing on master with 0.35.0 today either. |
it's just timeouts trying to fetch remote content so far, so may be caused by network conditions beyond the tests. |
@vasco-santos do you have a moment to take a look at why the tests aren't passing? |
|
@olizilla thanks for putting this together, I will have a look! |
Codecov Report
@@ Coverage Diff @@
## master #39 +/- ##
=======================================
Coverage 80.26% 80.26%
=======================================
Files 4 4
Lines 76 76
=======================================
Hits 61 61
Misses 15 15 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is good now. The ipfs-http-response
module needed to be updated as well, in order to provide the correct data do the service-worker-gateway
run the CI tests with [email protected]
of note, I'm seeing test failures locally on master as well as with
the latest ipfs 0.36 rc, so I'm sharing this PR to trigger CI to
see if it's just an issue on my machine.
see: ipfs/js-ipfs#2024