Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The big clean up #32

Merged
merged 8 commits into from
Feb 2, 2016
Merged

The big clean up #32

merged 8 commits into from
Feb 2, 2016

Conversation

daviddias
Copy link
Member

WIP

@daviddias
Copy link
Member Author

Let scrutiny begin

@RichardLitt @noffle @dignifiedquire can you CR the code please?

After finishing here, I'll bring https://github.com/diasdavid/registry-static to be part of the project instead of a dependency that gets run as a shell command, so that I can get more interesting stats and control of what it is doing.

@daviddias
Copy link
Member Author

There is a note on the README important to be able to run the tests https://github.com/diasdavid/registry-mirror/tree/refactor/the-big-clean-up#development

@dignifiedquire
Copy link
Member

Will check!

@RichardLitt
Copy link

I don't understand; what does this PR do?

@dignifiedquire
Copy link
Member

@diasdavid left some preliminary comments. Also travis is unhappy

@dignifiedquire dignifiedquire mentioned this pull request Feb 2, 2016
6 tasks
@hackergrrl
Copy link

@diasdavid: could we get some more context? What are the high-level goals of this refactor?

@daviddias
Copy link
Member Author

@dignifiedquire thank you for the CR, I've pushed changes following you comments :)

@RichardLitt @noffle Apologies for not being clear, this PR is the transformation of registry-mirror from a collection of hacks and glue to it all work to a more structured code base, where there is order, making contribution and debugging easier

@daviddias
Copy link
Member Author

@dignifiedquire travis is unhappy due to the missing 0.4.0 binary :)

@daviddias
Copy link
Member Author

Will move ahead and merge this one, to be able to go to the next step, merge registry-static into the mix :)

daviddias added a commit that referenced this pull request Feb 2, 2016
@daviddias daviddias merged commit f02c900 into master Feb 2, 2016
@daviddias daviddias deleted the refactor/the-big-clean-up branch February 2, 2016 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants