Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support go-ipfs 0.5 and Java 10+ #164

Closed
wants to merge 2 commits into from
Closed

Conversation

lidel
Copy link
Member

@lidel lidel commented Jun 2, 2020

This PR supersedes #160 #159 and #161

TODO

Tests do not pass, looks like there is no support for CIDv1/multibase:

@lidel
Copy link
Member Author

lidel commented Jun 2, 2020

@ianopolous my Java is rusty, would appreciate some guidance/tips on current best practices:

  • was there any particular reason why prebuilt .jar for java-multihash/multibase/cid are in this repo, or was it just for convenience?
  • are those libraries still maintained?
  • would it be ok to remove prebuilt .jar from this repo and switch to jitpack.io versions?

@ianopolous
Copy link
Collaborator

My view of source control in general is that I want to be able to check out any historical commit and be able to build it. If it relies on some external service to deliver assets (i.e. the dependencies aren't vendored) then that is not longer the case. But feel free to do what you want given I don't have time.

I've also fixed the base32 multibase issue in Peergos.

@odisseus
Copy link
Contributor

odisseus commented Jun 3, 2020

Some of the tests are failing because the versions of dependency libraries are outdated.

$ mvn dependency:tree
# ...snip...
com.github.ipfs:java-ipfs-http-client:jar:v1.2.3
+- com.github.multiformats:java-multiaddr:jar:v1.3.1:compile
|  \- com.github.ipld:java-cid:jar:v1.1.0:compile
|     +- com.github.multiformats:java-multibase:jar:v1.0.0:compile
|     \- com.github.multiformats:java-multihash:jar:v1.1.0:compile
+- junit:junit:jar:4.12:test
\- org.hamcrest:hamcrest-core:jar:1.3:test

The latest release of java-multiaddr seems to be using an outdated version of java-cid, which in turn uses outdated version of java-multihash.

Also, java-cid needs to be rebuilt against the very latest version of java-multihash, because of a change in its interface that leads to binary incompatibility.

@lidel
Copy link
Member Author

lidel commented Jul 29, 2020

Superseded by #170

@lidel lidel closed this Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants