WIP: Use the base class #41
Conversation
| return this.swarm.unhandle(protocol) | ||
| const libp2p = require('libp2p') | ||
|
|
||
| class Node extends libp2p.Node { |
There was a problem hiding this comment.
Sometimes inheritance is just awesome :)
|
It works \o/ So happy about this refactoring, makes things so much nicer and understandable @dignifiedquire Not sure if I should consider your comment as a positive CR, but I believe it is safe to assume that if you found an issue, you would comment right away :) Will merge once CI is green |
|
@diasdavid I didn't do any real CR yet will do tomorrow |
|
thank you :) |
|
while you are at it :) ipfs-inactive/js-libp2p-ipfs-browser#126 |
| this.routing = null | ||
| this.records = null | ||
| module.exports = { | ||
| Node: Node |
There was a problem hiding this comment.
just module.exports = Node
There was a problem hiding this comment.
So, my thinking is that spawning new libp2p.Node is more intuitive than spawning new Libp2p, would you agree?
There was a problem hiding this comment.
Specially in a library that its name is an ecosystem of stuff connecting to other stuff (abstraction ⛰ )
There was a problem hiding this comment.
not really, I would just like to write
const Node = require('libp2p-ipfs')
const myNode = new Node()
ref: libp2p/js-libp2p#43