This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started implementing ipfs-inactive/interface-js-ipfs-core#112 on js-ipfs-api, but there are somethings missing, from ipfs dag cli we have:
It would be great if we could use the multicodec names for the
format
flag, namely:It will solve a lot of ambiguity. Can we get that @whyrusleeping ?
Another thing, it has no option to pick the hash algorithm to use.
Last note, the
--input-enc
defaults to json, but if we can use the multicodec of the type, we could send them serialized directly.