This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
Header work #128
Merged
Header work #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dignifiedquire
force-pushed
the
headers
branch
from
8cb2b5b to
c211299
Compare
This was referenced Nov 20, 2015
| try { | ||
| parsed.push(JSON.parse(chunk)) | ||
| } catch (err) { | ||
| // Browser quirks emit more than needed sometimes |
There was a problem hiding this comment.
Emit more than needed? What does this exactly mean? :)
There was a problem hiding this comment.
if you have 3 chunks, you sometimes get:
- chunk1
- chunk2
- chunk3
- chunk1+chunk2 => not parsable
do not ask me why, browsers are a weird bunch..
There was a problem hiding this comment.
What I'm thinking is that "stream" and "chunked" should not exist at the same time. "chunked" is a stream made of small parts of the same files, they should not be parsed individually. "stream" in the another hand, it is the ndjson stuff :)
There was a problem hiding this comment.
Correct, but "chunked" is represented as a (node) stream where each individual emitted event is equal to one chunk, that's why we are parsing it this way
|
LGTM :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal: Fix #76 still not there though..
When ipfs/kubo#1979 is merged we can remove the config settings in the daemon setup