This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
chore: converts remaining files api to async iterators #1124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achingbrain
force-pushed
the
add-async-iterator-methods
branch
from
2c784f1 to
7e9a0ee
Compare
hugomrdias
approved these changes
Oct 7, 2019
daviddias
suggested changes
Oct 10, 2019
| const promisify = require('promisify-es6') | ||
| const configure = require('../lib/configure') | ||
| const tarStreamToObjects = require('../utils/tar-stream-to-objects') | ||
| const IsIpfs = require('is-ipfs') |
There was a problem hiding this comment.
Suggested change
| const IsIpfs = require('is-ipfs') | |
| const isIpfs = require('is-ipfs') |
Reserve Capital for Constructors
There was a problem hiding this comment.
Maybe it's my Java showing but this looks natural to me 🤣
Isn't this the sort of thing we have a linter for?
|
|
||
| try { | ||
| path = cleanCID(path) | ||
| } catch (err) { | ||
| if (!v.ipfsPath(path)) { | ||
| return callback(err) | ||
| if (!IsIpfs.ipfsPath(path)) { |
There was a problem hiding this comment.
Suggested change
| if (!IsIpfs.ipfsPath(path)) { | |
| if (!isIpfs.ipfsPath(path)) { |
| @@ -1,64 +1,72 @@ | |||
| 'use strict' | |||
|
|
|||
| const promisify = require('promisify-es6') | |||
| const IsIpfs = require('is-ipfs') | |||
There was a problem hiding this comment.
Suggested change
| const IsIpfs = require('is-ipfs') | |
| const isIpfs = require('is-ipfs') |
| } catch (err) { | ||
| if (!IsIpfs.ipfsPath(args)) { | ||
| return callback(err) | ||
| if (!IsIpfs.ipfsPath(path)) { |
There was a problem hiding this comment.
Suggested change
| if (!IsIpfs.ipfsPath(path)) { | |
| if (!isIpfs.ipfsPath(path)) { |
| const cleanCID = require('../utils/clean-cid') | ||
| const IsIpfs = require('is-ipfs') |
There was a problem hiding this comment.
Suggested change
| const IsIpfs = require('is-ipfs') | |
| const isIpfs = require('is-ipfs') |
|
I'm going to merge this to unblock ipfs/js-ipfs#2517 - have opened ipfs/aegir#449 to discuss the capitalisation thing further. The lines of code in question were pre-existing in the codebase, so let's not widen the scope of this PR. Happy to open another for general improvements if we decide it's a good idea. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.