This repository has been archived by the owner on Apr 29, 2020. It is now read-only.
Added Group tar
#53
Merged
Added Group tar
#53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 'ipfs tar add' will parse a tar file and create a merkledag structure to represent it. | ||
|
|
||
| + Parameters | ||
| + arg (string, required) - tar file to add |
There was a problem hiding this comment.
Is this the file itself or the path to the tar file?
There was a problem hiding this comment.
The file itself. How can I make that clearer?
There was a problem hiding this comment.
Not sure :/ cc @diasdavid
|
@diasdavid or @dignifiedquire: review? |
|
LGTM |
| + Headers | ||
|
|
||
| ``` | ||
| Access-Control-Allow-Headers: X-Stream-Output, X-Chunked-Output |
There was a problem hiding this comment.
Nice, no ouptut anymore, I've noticed that in go-ipfs too :)
There was a problem hiding this comment.
Ahahaha I never noticed that.
|
LGTM overall :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.