This repository has been archived by the owner on Apr 29, 2020. It is now read-only.
Added group log
#39
Merged
Added group log
#39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| - dht | ||
| - merkledag | ||
| - all | ||
| + arg2 (enum[string]) |
There was a problem hiding this comment.
Missing description of arg2
There was a problem hiding this comment.
There is no description for arg2 in the CLI. Thoughts?
There was a problem hiding this comment.
Maybe sth like this - The log level, withdebugthe most verbose andpanicthe least verbose.
Also are these two args optional or required, if they are optional what is the default value :P
RichardLitt
force-pushed
the
feature/log
branch
from
42cf307 to
54d64a0
Compare
RichardLitt
force-pushed
the
feature/log
branch
from
54d64a0 to
059958a
Compare
|
Waiting on #2362. |
|
I think this is done now. RFM? |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is dependent on ipfs/kubo#2305 being merged, in case subsystem is not an enumerated type list, and in case all of the possible types are not mentioned.