-
Notifications
You must be signed in to change notification settings - Fork 22
Conversation
``` | ||
|
||
## wantlist [GET /bitswap/wantlist{?peer}] | ||
Show blocks currently on the wantlist. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- of a peer or itself
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand the context for this comment: can you rephrase?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because if the param 'peer' is passed, we will see the want list that we have from that peer, if we don't pass anything, our own want list will be shown
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Covered in the options. See updated code.
Looks like we are starting to get some material we can open issues on go-ipfs :) |
Seems like other than the tiny tid bit here #24 (comment), this is ready to be rebased and clean merged? |
needs rebase |
bitswap
and its three subcommandsbitswap
Found a bug in the docs where the ability to add multiple keys isn't mentioned. Open PR. ipfs/kubo#2409 @whyrusleeping must the key in |
1c752af
to
49d926f
Compare
Fixed that bug, #2409 is closed. Key is synonymous with multihash, so, yes, and b58 always returns an empty string when decoded like that. So. This is all good. |
I added
ipfs bitswap stat
,wantlist
, andunwant
. I also added an Error object data structure for better error logging for future requests.