Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt: remove disable-address-verify flag #127

Merged
merged 2 commits into from
Apr 13, 2023
Merged

opt: remove disable-address-verify flag #127

merged 2 commits into from
Apr 13, 2023

Conversation

simlecode
Copy link
Collaborator

@simlecode simlecode commented Apr 13, 2023

关联的Issues (Related Issues)

close filecoin-project/venus#5800

改动 (Proposed Changes)

移除 flag:disable-address-verify

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@simlecode simlecode self-assigned this Apr 13, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #127 (bc3f892) into master (b50783f) will decrease coverage by 0.32%.
The diff coverage is 73.68%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #127      +/-   ##
==========================================
- Coverage   63.13%   62.82%   -0.32%     
==========================================
  Files          30       30              
  Lines        2189     2141      -48     
==========================================
- Hits         1382     1345      -37     
+ Misses        735      725      -10     
+ Partials       72       71       -1     
Flag Coverage Δ
unittests 62.82% <73.68%> (-0.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
config/config.go 81.25% <ø> (-0.57%) ⬇️
main.go 0.00% <0.00%> (ø)
metrics/metrics.go 100.00% <ø> (ø)
testhelper/memwallet.go 57.97% <60.00%> (-0.22%) ⬇️
api/rpc_impl.go 93.33% <66.66%> (-0.42%) ⬇️
walletevent/wallet_event.go 74.45% <71.42%> (+0.32%) ⬆️
integrate_test/mock_deamon.go 81.25% <100.00%> (ø)
marketevent/market_client.go 67.01% <100.00%> (-0.59%) ⬇️
marketevent/market_event.go 91.07% <100.00%> (+0.63%) ⬆️
testhelper/testhelper.go 95.74% <100.00%> (-0.81%) ⬇️

... and 2 files with indirect coverage changes

@simlecode simlecode requested a review from hunjixin April 13, 2023 08:14
@hunjixin hunjixin merged commit dffe5de into master Apr 13, 2023
@hunjixin hunjixin deleted the opt/remove-flag branch April 13, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[venus-gateway] Remove flag --disable-address-verify / 移除flag --disable-address-verify
3 participants