Update pydantic and fastapi #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omarudolley
changed the title
joakimnordling
requested changes
Oct 27, 2023
There was a problem hiding this comment.
- The test are now raising a warning
Field "model_name" has conflict with protected namespace "model_"., seems to be caused by a field with that name inParsedResponseinopenapi_to_fastapi/models.py. Would be nice if we could fix that warning, preferably by finding some good alternative name for the field. - I'd want to see at least some tests that use OpenAPI 3.1.0 based definitions to ensure this update will work with the upcoming changes from Update Pydantic to v2.4.2 ioxio-dataspace/ioxio-data-product-definition-tooling#22.
- The version number of the library needs to be updated before we can release it.
Co-authored-by: Joakim Nordling <[email protected]>
joakimnordling
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update pydantic and fastapi to latest version