Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove IHAN validator #32

Merged
merged 2 commits into from
Aug 9, 2023
Merged

Remove IHAN validator #32

merged 2 commits into from
Aug 9, 2023

Conversation

fbjorn
Copy link
Collaborator

@fbjorn fbjorn commented Aug 7, 2023

Remove IHAN validator, but still keeping the opportunity to write custom ones

@fbjorn fbjorn requested a review from joakimnordling August 7, 2023 14:04
joakimnordling
joakimnordling approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@joakimnordling joakimnordling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. You could possibly consider still to extend FastAPI version range to cover the 0.99.x versions still (now limited to <0.99; 0.100 adds Pydantic 2, so that might break things, but 0.99.x should likely work just fine).

@fbjorn fbjorn merged commit ada9da4 into main Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joakimnordling joakimnordling joakimnordling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fbjorn @joakimnordling