-
Notifications
You must be signed in to change notification settings - Fork 7
Increase operator support #14
base: main
Are you sure you want to change the base?
Conversation
I would prefer to replace spaces in dict keys with
or something? People would still be free to use the string values if they wanted to, but we'd have typing to assist. |
@lietu True, good idea as well. What do you think about the "contains" support? I didn't really think of any better way of "reversing" the fields. |
|
@lietu Did some refactoring on this. Review when convenient. Thanks! |
# Operators.GTE (>=) | ||
# Operators.IN | ||
# Operators.NOT_IN | ||
# Operators.ALL_IN |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Too much poker? 😄
Except the 2 references to |
What 2 references? The other one is |
@lietu also, I removed the "reverse" order of the array comparison. It's not necessary now that we support all the array comparison operators. |
Add support for `IN` and `NOT IN` operators when querying for arrays. Also add the "reverse" of `IN` and `NOT IN`, i.e. `contains` and `not contains`, which checks if the given parameter is found in an array of the model attribute.
Add more array comparison operators and move them into their own enum class for easier usage.
The array comparison happens in the same way as normal comparison. Now that we have support for the different types, the comparison should be done correctly.
473d2ab
to
fb85613
Compare
Add more operators, such as LIKE, NOT LIKE, =~ and !~. The latter are for regular expression matches. Also add support for all the array comparison operators. The array operators are a bit special, since the ANY, ALL and NONE requires an additional operator, such as ==, !=, >, etc. to match against the individual keys in the array. Add test cases for all the operators from ArangoDB documentation, to keep the tests up to par with the docs.
@joakimnordling The tests are now updated and more operator support added. |
Add support for
IN
andNOT IN
operators when querying for arrays.Also add the "reverse" of
IN
andNOT IN
, i.e.contains
andnot contains
, which checks if the given parameter is found in an array ofthe model attribute.