Enable and cleanup the signupPass dom test #203
Conversation
|
Travis automatic deployment: Storybook book automatic deployment: |
|
Travis automatic deployment: Storybook book automatic deployment: |
| @@ -115,3 +115,10 @@ async function watchAccountAndTransactions( | |||
|
|
|||
| return account; // resolved when first account is loaded | |||
| } | |||
|
|
|||
| export function shutdownSequence(_: any, getState: () => RootState): void { | |||
There was a problem hiding this comment.
@ethanfrey Why this first argument?
There was a problem hiding this comment.
Unless I am wrong I would do:
export function shutdownSequence(state: RootState): void {
...
and just call it like: shutdownSequence(store.getState())
What do you think?
There was a problem hiding this comment.
I left this here, so it can be called like a thunk (eg. dispatch(shutdownSequence) will work). Outside of tests, we rarely have access to the state
src/sequences/boot.ts
Outdated
|
|
||
| export function shutdownSequence(_: any, getState: () => RootState): void { | ||
| const connections = getConnections(getState()); | ||
| for (const conn of Object.values(connections)) { |
There was a problem hiding this comment.
What about:
Object.values(connections).map(conn => conn.disconnect())
?
There was a problem hiding this comment.
or maybe even better forEach
There was a problem hiding this comment.
I like that with forEach
| beforeEach(() => { | ||
| store = aNewStore(); | ||
| }); | ||
| afterEach(() => { |
There was a problem hiding this comment.
Much nicer... I like this 👍
|
Only got a verbal approval from Adolfo on slack, so I have to use my super-cow-powers to perform an illegal merge. |
|
Travis automatic deployment: Storybook book automatic deployment: |
This should allow adolfo's first dom test
Checks first box in #121