Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CosmJS implementations in crypto/encoding/utils #1441

Merged
merged 4 commits into from
Jun 17, 2020

Conversation

webmaster128
Copy link
Contributor

@webmaster128 webmaster128 commented Jun 16, 2020

Trim down codebase in a backwards compatible way by using @cosmjs/* packages (required by @iov/cosmos-sdk already). This prepares IOV Core 3.0.

@webmaster128 webmaster128 requested a review from davepuchyr June 16, 2020 09:58
Copy link
Contributor

@davepuchyr davepuchyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bump in the version major is going to look strange since it comes with a lot less code. :)

@webmaster128 webmaster128 merged commit d290b0c into master Jun 17, 2020
@webmaster128 webmaster128 deleted the use-cosm-js-in-encoding branch June 17, 2020 09:37
@webmaster128
Copy link
Contributor Author

This can be released as 2.5.0 since it only swaps out implementations and does not break interfaces. Then you can do the 3.0 as part of the mainnet transition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants