Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port/linux: Address Issues with ENOBUF Failure in Netlink IP Address Retrieval #602

Merged
merged 1 commit into from
Feb 3, 2024

Conversation

jkralik
Copy link
Member

@jkralik jkralik commented Jan 30, 2024

In some cases, it can lead to issues because if the IP addresses are obtained through netlink and there is a failure due to ENOBUF, the device may report incorrect endpoints during the discovery process.

@jkralik jkralik requested a review from Danielius1922 January 30, 2024 12:33
@ocf-conformance-test-tool
Copy link

🎉 Thank you for your code contribution! To guarantee the change/addition is conformant to the OCF Specification, we would like to ask you to execute OCF Conformance Testing of your change ☝️ when your work is ready to be reviewed.


ℹ️ To verify your latest change (a486d17), label this PR with OCF Conformance Testing.

⚠️ Label is removed with every code change.

@jkralik jkralik force-pushed the jkralik/fix/netlink-enobuf branch from a486d17 to 36dd732 Compare January 30, 2024 12:47
…Retrieval

In some cases, it can lead to issues because if the IP addresses
are obtained through netlink and there is a failure due to ENOBUF,
the device may report incorrect endpoints during the discovery process.
@jkralik jkralik force-pushed the jkralik/fix/netlink-enobuf branch from 36dd732 to f4d26ee Compare January 30, 2024 12:52
Copy link

sonarcloud bot commented Jan 30, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

40.9% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@Danielius1922 Danielius1922 added the OCF Conformance Testing OCF Conformance Testing required label Feb 2, 2024
@Danielius1922 Danielius1922 merged commit 67ebdb1 into master Feb 3, 2024
122 of 123 checks passed
@Danielius1922 Danielius1922 deleted the jkralik/fix/netlink-enobuf branch February 3, 2024 13:51
@github-actions github-actions bot locked and limited conversation to collaborators Feb 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
OCF Conformance Testing OCF Conformance Testing required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants