Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update query public API #524

Closed
wants to merge 1 commit into from
Closed

Conversation

Danielius1922
Copy link
Member

Extend the function signature to include the include the length of the key. If the length of the key is known then a call to strlen can be avoided.

Added:

  • oc_iterate_query_get_values_v1
  • oc_get_query_value_v1
  • oc_query_value_exists_v1
  • oc_ri_get_query_value_v1
  • oc_ri_query_exists_v1

Deprecated:

  • oc_iterate_query_get_values
  • oc_get_query_value
  • oc_query_value_exists
  • oc_ri_get_query_value
  • oc_ri_query_exists

@ocf-conformance-test-tool
Copy link

🎉 Thank you for your code contribution! To guarantee the change/addition is conformant to the OCF Specification, we would like to ask you to execute OCF Conformance Testing of your change ☝️ when your work is ready to be reviewed.


ℹ️ To verify your latest change (5aa7010), label this PR with OCF Conformance Testing.

⚠️ Label is removed with every code change.

Extend the function signature to include the include the length
of the key. If the length of the key is known then a call to
strlen can be avoided.

Added:
  - oc_iterate_query_get_values_v1
  - oc_get_query_value_v1
  - oc_query_value_exists_v1
  - oc_ri_get_query_value_v1
  - oc_ri_query_exists_v1

Deprecated:
  - oc_iterate_query_get_values
  - oc_get_query_value
  - oc_query_value_exists
  - oc_ri_get_query_value
  - oc_ri_query_exists
@Danielius1922 Danielius1922 force-pushed the adam/feature/etag-incremental branch from 5aa7010 to a7566c8 Compare September 8, 2023 14:09
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 8, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 5 Security Hotspots
Code Smell A 20 Code Smells

81.4% 81.4% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@github-actions github-actions bot locked and limited conversation to collaborators Sep 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant