Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: fix coverity issues #474

Merged
merged 6 commits into from
Jun 29, 2023
Merged

Conversation

Danielius1922
Copy link
Member

@Danielius1922 Danielius1922 commented Jun 26, 2023

Fixes #467
Issue 321044: Out-of-bounds write

@ocf-conformance-test-tool
Copy link

🎉 Thank you for your code contribution! To guarantee the change/addition is conformant to the OCF Specification, we would like to ask you to execute OCF Conformance Testing of your change ☝️ when your work is ready to be reviewed.


ℹ️ To verify your latest change (cf42f26), label this PR with OCF Conformance Testing.

⚠️ Label is removed with every code change.

@Danielius1922 Danielius1922 force-pushed the adam/bugfix/467-coverity-fixes-3 branch 7 times, most recently from 8a0dc41 to c6b5c94 Compare June 27, 2023 13:56
Issue 321044: Out-of-bounds write
319213: Untrusted loop bound

319262: Logically dead code
@Danielius1922 Danielius1922 force-pushed the adam/bugfix/467-coverity-fixes-3 branch 3 times, most recently from fe8671c to 4589494 Compare June 27, 2023 14:34
@Danielius1922 Danielius1922 requested a review from jkralik June 27, 2023 15:11
@Danielius1922 Danielius1922 added the OCF Conformance Testing OCF Conformance Testing required label Jun 27, 2023
@Danielius1922 Danielius1922 marked this pull request as ready for review June 27, 2023 15:11
messaging/coap/observe.c Outdated Show resolved Hide resolved
messaging/coap/observe.c Outdated Show resolved Hide resolved
messaging/coap/observe.c Show resolved Hide resolved
319204: Resource leak

319225, 319233: Out-of-bounds access

319244: Resource leak

319252: Resource leak

319243: Out-of-bounds access
319214: Resource leak
319236, 319242: Unchecked return value
319210: Unitialized variables in oc_oscore_engine.c

319251: Resource leak in oc_oscore_context.c

319203, 319207, 319216, 319222, 319231, 319232, 319246, 319258:
  Resource leak in oc_obt.c

319217, 319227, 319229: Out-of-bounds access in
  oc_conv_byte_array_to_hex_string

319228: Uninitialized scalar variable in oc_obt.c
@Danielius1922 Danielius1922 force-pushed the adam/bugfix/467-coverity-fixes-3 branch from 4589494 to 0acf112 Compare June 29, 2023 10:16
@ocf-conformance-test-tool ocf-conformance-test-tool bot removed the OCF Conformance Testing OCF Conformance Testing required label Jun 29, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jun 29, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 6 Security Hotspots
Code Smell A 5 Code Smells

40.9% 40.9% Coverage
12.7% 12.7% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@Danielius1922 Danielius1922 merged commit 2688ad4 into master Jun 29, 2023
@Danielius1922 Danielius1922 deleted the adam/bugfix/467-coverity-fixes-3 branch June 29, 2023 12:01
@github-actions github-actions bot locked and limited conversation to collaborators Jun 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coverity issues
2 participants