Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor GetEpochMeta API #848

Merged
merged 2 commits into from
Mar 26, 2019
Merged

Refactor GetEpochMeta API #848

merged 2 commits into from
Mar 26, 2019

Conversation

lizhefeng
Copy link
Contributor

EpochMeta now contains:

  1. EpochData(epoch number, epoch start height, gravity chain start height);
  2. Total Number of Blocks;
  3. []BlockProducerInfo (Address, Votes, Active or Not, Block Productions)

Comment out all the delegate related part in ioctl for now, as it needs to be refactored accordingly.

@lizhefeng lizhefeng requested a review from a team as a code owner March 26, 2019 07:38
@codecov
Copy link

codecov bot commented Mar 26, 2019

Codecov Report

Merging #848 into master will decrease coverage by 0.02%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #848      +/-   ##
==========================================
- Coverage   58.76%   58.73%   -0.03%     
==========================================
  Files         149      149              
  Lines       12263    12267       +4     
==========================================
- Hits         7206     7205       -1     
- Misses       4093     4097       +4     
- Partials      964      965       +1
Impacted Files Coverage Δ
blockchain/blockchain.go 48.22% <0%> (ø) ⬆️
action/protocol/poll/protocol.go 19.49% <0%> (-0.43%) ⬇️
api/api.go 64.02% <80%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c6bbfe...74306bc. Read the comment docs.

@lizhefeng lizhefeng merged commit 1891787 into iotexproject:master Mar 26, 2019
zjshen14 pushed a commit that referenced this pull request Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants