Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mute error messages #840

Merged
merged 1 commit into from
Mar 25, 2019
Merged

Conversation

CoderZhi
Copy link
Collaborator

  1. Mute commit error if the cause is tip height error
  2. Mute minicluster wrong height alert
  3. Mute consensus error when height is 0
  4. Update election logging information

@CoderZhi CoderZhi requested a review from a team as a code owner March 25, 2019 22:09
@codecov
Copy link

codecov bot commented Mar 25, 2019

Codecov Report

Merging #840 into master will increase coverage by 0.02%.
The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #840      +/-   ##
==========================================
+ Coverage   58.65%   58.67%   +0.02%     
==========================================
  Files         149      149              
  Lines       12225    12233       +8     
==========================================
+ Hits         7170     7178       +8     
+ Misses       4092     4090       -2     
- Partials      963      965       +2
Impacted Files Coverage Δ
consensus/scheme/rolldpos/rolldpos.go 63.09% <0%> (-1.15%) ⬇️
blocksync/buffer.go 92.95% <100%> (ø) ⬆️
consensus/scheme/rolldpos/rolldposctx.go 63.15% <50%> (-0.05%) ⬇️
action/protocol/rewarding/reward.go 72% <0%> (-1.76%) ⬇️
db/trie/branchnode.go 67.2% <0%> (+1.6%) ⬆️
db/trie/extensionnode.go 59.32% <0%> (+1.69%) ⬆️
action/protocol/rewarding/protocol.go 48.83% <0%> (+4.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e85759...cbe6c4e. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Mar 25, 2019

Codecov Report

Merging #840 into master will increase coverage by 0.02%.
The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #840      +/-   ##
==========================================
+ Coverage   58.65%   58.67%   +0.02%     
==========================================
  Files         149      149              
  Lines       12225    12233       +8     
==========================================
+ Hits         7170     7178       +8     
+ Misses       4092     4090       -2     
- Partials      963      965       +2
Impacted Files Coverage Δ
consensus/scheme/rolldpos/rolldpos.go 63.09% <0%> (-1.15%) ⬇️
blocksync/buffer.go 92.95% <100%> (ø) ⬆️
consensus/scheme/rolldpos/rolldposctx.go 63.15% <50%> (-0.05%) ⬇️
action/protocol/rewarding/reward.go 72% <0%> (-1.76%) ⬇️
db/trie/branchnode.go 67.2% <0%> (+1.6%) ⬆️
db/trie/extensionnode.go 59.32% <0%> (+1.69%) ⬆️
action/protocol/rewarding/protocol.go 48.83% <0%> (+4.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e85759...cbe6c4e. Read the comment docs.

@CoderZhi CoderZhi merged commit fb5ffce into iotexproject:master Mar 25, 2019
@CoderZhi CoderZhi deleted the mute_some_errors branch March 25, 2019 23:25
zjshen14 pushed a commit that referenced this pull request Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants