Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve hash cmd for ioctl #836

Merged
merged 3 commits into from
Mar 25, 2019
Merged

Improve hash cmd for ioctl #836

merged 3 commits into from
Mar 25, 2019

Conversation

Frankonly
Copy link
Contributor

@Frankonly Frankonly commented Mar 24, 2019

Tested on local

→  ioctl action hash 690fb07fbb5ba3b762a7a16edea35ff1c3b02b43a6331aef88c4daa1bc933ad4

version: 1  nonce: 7  gasLimit: 122222  gasPrice: 2000000000000 Rau
senderAddress: io1znka733xefxjjw2wqddegplwtefun0mfdmz7dw (whale)
transfer: <
  recipient: io18jaldgzc8wlyfnzamgas62yu3kg5nw527czg37 (nani)
  amount: 123000000000000000000 Rau
  payload:
>
senderPubKey: 04d0fade363080b9061844ed6b1009f35595515b31295e37e870106d3201a638856db2c3f870dbbcafc559af54574f3487dbea0d318588608d7aca8e77e4ce5ade
signature: 2e10f265fdc5944fab11afaebd258292afe8f9076157fbaca6bfdd3ece9047483fb3aa10ce187fe55d2d9c591e5eda430833b744f825a6ae34c9b34461d3940f01

#This action has been written on blockchain
returnValue:
status: 1 (Success)
actHash: 690fb07fbb5ba3b762a7a16edea35ff1c3b02b43a6331aef88c4daa1bc933ad4
gasConsumed: 10000
contractAddress:
logs:
[]

@Frankonly Frankonly requested a review from a team as a code owner March 24, 2019 00:17
@codecov
Copy link

codecov bot commented Mar 25, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@6b4621e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #836   +/-   ##
========================================
  Coverage          ?   58.6%           
========================================
  Files             ?     149           
  Lines             ?   12173           
  Branches          ?       0           
========================================
  Hits              ?    7134           
  Misses            ?    4082           
  Partials          ?     957

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b4621e...6c95644. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Mar 25, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@6b4621e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #836   +/-   ##
========================================
  Coverage          ?   58.6%           
========================================
  Files             ?     149           
  Lines             ?   12173           
  Branches          ?       0           
========================================
  Hits              ?    7134           
  Misses            ?    4082           
  Partials          ?     957

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b4621e...6c95644. Read the comment docs.

@Frankonly Frankonly requested a review from raullenchai March 25, 2019 17:53
@raullenchai raullenchai merged commit 49350d0 into iotexproject:master Mar 25, 2019
@Frankonly Frankonly deleted the hash branch March 25, 2019 18:02
zjshen14 pushed a commit that referenced this pull request Mar 26, 2019
* Improve hash cmd for ioctl

* update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants