Add GetEpochData API #831

lizhefeng · 2019-03-23T08:00:16Z

Given an epoch number, GetEpochData would return the epochData(epoch number, epoch start height, gravity chain start height), block producers' productivity in the epoch, and bp list for the next epoch if it exists.

api/api_test.go

api/api.go

codecov · 2019-03-23T08:27:20Z

Codecov Report

Merging #831 into master will increase coverage by 0.07%.
The diff coverage is 70.14%.

@@            Coverage Diff             @@
##           master     #831      +/-   ##
==========================================
+ Coverage   58.42%   58.49%   +0.07%     
==========================================
  Files         149      149              
  Lines       12169    12221      +52     
==========================================
+ Hits         7110     7149      +39     
- Misses       4104     4110       +6     
- Partials      955      962       +7

Impacted Files	Coverage Δ
api/api.go	`63.2% <70.14%> (+1.05%)`	⬆️
db/trie/extensionnode.go	`59.32% <0%> (+1.69%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bc8415...37d4de6. Read the comment docs.

codecov · 2019-03-23T08:27:20Z

Codecov Report

Merging #831 into master will increase coverage by 0.07%.
The diff coverage is 70.14%.

@@            Coverage Diff             @@
##           master     #831      +/-   ##
==========================================
+ Coverage   58.42%   58.49%   +0.07%     
==========================================
  Files         149      149              
  Lines       12169    12221      +52     
==========================================
+ Hits         7110     7149      +39     
- Misses       4104     4110       +6     
- Partials      955      962       +7

Impacted Files	Coverage Δ
api/api.go	`63.2% <70.14%> (+1.05%)`	⬆️
db/trie/extensionnode.go	`59.32% <0%> (+1.69%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bc8415...37d4de6. Read the comment docs.

codecov · 2019-03-23T08:27:21Z

Codecov Report

Merging #831 into master will increase coverage by 0.07%.
The diff coverage is 70.14%.

@@            Coverage Diff             @@
##           master     #831      +/-   ##
==========================================
+ Coverage   58.42%   58.49%   +0.07%     
==========================================
  Files         149      149              
  Lines       12169    12221      +52     
==========================================
+ Hits         7110     7149      +39     
- Misses       4104     4110       +6     
- Partials      955      962       +7

Impacted Files	Coverage Δ
api/api.go	`63.2% <70.14%> (+1.05%)`	⬆️
db/trie/extensionnode.go	`59.32% <0%> (+1.69%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bc8415...37d4de6. Read the comment docs.

codecov · 2019-03-23T08:27:21Z

Codecov Report

❗ No coverage uploaded for pull request base (master@6b4621e). Click here to learn what that means.
The diff coverage is 70.14%.

@@            Coverage Diff            @@
##             master     #831   +/-   ##
=========================================
  Coverage          ?   58.49%           
=========================================
  Files             ?      149           
  Lines             ?    12221           
  Branches          ?        0           
=========================================
  Hits              ?     7149           
  Misses            ?     4110           
  Partials          ?      962

Impacted Files	Coverage Δ
api/api.go	`63.2% <70.14%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b4621e...f8badcf. Read the comment docs.

zjshen14

Shall we rename GetProductivity to GeEpochMeta, although it's a breaking change?

golangcibot · 2019-03-25T21:49:02Z

api/api_test.go

@@ -478,6 +479,45 @@ var (
 			numCommitteeBlockProducers: 1,
 		},
 	}
+
+	getEpochMetaTests = []struct {


getEpochMetaTests is a global variable (from gochecknoglobals)

lizhefeng requested a review from a team as a code owner March 23, 2019 08:00

golangcibot reviewed Mar 23, 2019

View reviewed changes

api/api_test.go Outdated Show resolved Hide resolved

api/api_test.go Outdated Show resolved Hide resolved

api/api.go Show resolved Hide resolved

zjshen14 reviewed Mar 23, 2019

View reviewed changes

zjshen14 added the 0.5.0-rc6 label Mar 23, 2019

lizhefeng added the breaking change label Mar 25, 2019

golangcibot reviewed Mar 25, 2019

View reviewed changes

lizhefeng added 2 commits March 25, 2019 14:57

Add GetEpochData API

61d3765

Merge GetProductivity into GetEpochData

6d9aa8d

CoderZhi approved these changes Mar 25, 2019

View reviewed changes

lizhefeng merged commit 48410a1 into iotexproject:master Mar 25, 2019

zjshen14 pushed a commit that referenced this pull request Mar 26, 2019

Add GetEpochData API (#831)

78ede89

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add GetEpochData API #831

Add GetEpochData API #831

lizhefeng commented Mar 23, 2019

codecov bot commented Mar 23, 2019

codecov bot commented Mar 23, 2019

codecov bot commented Mar 23, 2019

codecov bot commented Mar 23, 2019 •

edited

Loading

zjshen14 left a comment

golangcibot Mar 25, 2019

Add GetEpochData API #831

Add GetEpochData API #831

Conversation

lizhefeng commented Mar 23, 2019

codecov bot commented Mar 23, 2019

Codecov Report

codecov bot commented Mar 23, 2019

Codecov Report

codecov bot commented Mar 23, 2019

Codecov Report

codecov bot commented Mar 23, 2019 • edited Loading

Codecov Report

zjshen14 left a comment

Choose a reason for hiding this comment

golangcibot Mar 25, 2019

Choose a reason for hiding this comment

codecov bot commented Mar 23, 2019 •

edited

Loading