Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove CreationHeight and LastUpdateHeight from Candidate #827

Merged
merged 2 commits into from
Mar 23, 2019
Merged

remove CreationHeight and LastUpdateHeight from Candidate #827

merged 2 commits into from
Mar 23, 2019

Conversation

CoderZhi
Copy link
Collaborator

Remove these two legacy fields

@CoderZhi CoderZhi requested a review from a team as a code owner March 22, 2019 23:35
@codecov
Copy link

codecov bot commented Mar 23, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@410627c). Click here to learn what that means.
The diff coverage is 76.92%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #827   +/-   ##
=========================================
  Coverage          ?   58.43%           
=========================================
  Files             ?      149           
  Lines             ?    12138           
  Branches          ?        0           
=========================================
  Hits              ?     7093           
  Misses            ?     4095           
  Partials          ?      950
Impacted Files Coverage Δ
explorer/explorer.go 56.34% <66.66%> (ø)
state/candidate.go 72.05% <85.71%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 410627c...b9448a0. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Mar 23, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@410627c). Click here to learn what that means.
The diff coverage is 76.92%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #827   +/-   ##
=========================================
  Coverage          ?   58.43%           
=========================================
  Files             ?      149           
  Lines             ?    12138           
  Branches          ?        0           
=========================================
  Hits              ?     7093           
  Misses            ?     4095           
  Partials          ?      950
Impacted Files Coverage Δ
explorer/explorer.go 56.34% <66.66%> (ø)
state/candidate.go 72.05% <85.71%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 410627c...b9448a0. Read the comment docs.

@zjshen14 zjshen14 merged commit dc26643 into iotexproject:master Mar 23, 2019
zjshen14 pushed a commit that referenced this pull request Mar 24, 2019
@CoderZhi @zjshen14
remove CreationHeight and LastUpdateHeight from Candidate (#827)
3431fcf
@CoderZhi CoderZhi deleted the delete_redundant_fields_in_candidate branch April 25, 2019 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raullenchai raullenchai raullenchai approved these changes

@zjshen14 zjshen14 zjshen14 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CoderZhi @raullenchai @zjshen14