Handle empty reward address and fix available balance acccounting #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raullenchai
approved these changes
Mar 23, 2019
| if rewardAddrStr == "" { | ||
| return errors.Errorf("Producer %s doesn't have a reward address", producerAddrStr) | ||
| return nil |
Codecov Report
@@ Coverage Diff @@
## master #826 +/- ##
==========================================
- Coverage 58.42% 58.21% -0.21%
==========================================
Files 149 146 -3
Lines 12169 12168 -1
==========================================
- Hits 7110 7084 -26
- Misses 4104 4135 +31
+ Partials 955 949 -6
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #826 +/- ##
==========================================
- Coverage 58.42% 58.21% -0.21%
==========================================
Files 149 146 -3
Lines 12169 12168 -1
==========================================
- Hits 7110 7084 -26
- Misses 4104 4135 +31
+ Partials 955 949 -6
Continue to review full report at Codecov.
|
zjshen14
added a commit
that referenced
this pull request
Mar 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested via unit tests