Remove admin and its operations from rewarding protocol #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raullenchai
approved these changes
Mar 14, 2019
| @@ -187,15 +148,6 @@ func (p *Protocol) BlockReward( | |||
| return a.blockReward, nil | |||
| } | |||
|
|
|||
| // SetBlockReward sets the block reward amount for the block rewarding. Only the current admin could make this change | |||
| func (p *Protocol) SetBlockReward( | |||
There was a problem hiding this comment.
Should we keep this one? My thinking is, when time comes, we will have a logic in minting a new block:
if (tip height == 50000000 && rewarding params != new rewarding params) {
SetBlockReward(new rewarding params)
}
There was a problem hiding this comment.
SetBlockReward has some logic that depends on admin to exist. It should not be hard when we want to hard fork and overwrite the block/epoch amount
zjshen14
added a commit
that referenced
this pull request
Mar 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.