Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md #666

Merged
merged 4 commits into from
Mar 5, 2019
Merged

Update CONTRIBUTING.md #666

merged 4 commits into from
Mar 5, 2019

Conversation

yutongp
Copy link
Contributor

@yutongp yutongp commented Mar 4, 2019

No description provided.

@yutongp yutongp requested a review from a team as a code owner March 4, 2019 22:48
@zjshen14
Copy link
Contributor

zjshen14 commented Mar 4, 2019

@codecov
Copy link

codecov bot commented Mar 5, 2019

Codecov Report

Merging #666 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #666      +/-   ##
==========================================
- Coverage   60.09%   60.07%   -0.03%     
==========================================
  Files         132      132              
  Lines       12560    12548      -12     
==========================================
- Hits         7548     7538      -10     
+ Misses       3972     3970       -2     
  Partials     1040     1040
Impacted Files Coverage Δ
pkg/keypair/keypair.go 65.21% <0%> (-8.98%) ⬇️
consensus/scheme/rolldpos/rolldposctx.go 75.11% <0%> (-0.46%) ⬇️
pkg/keypair/secp256k1.go 90.9% <0%> (+7.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db49482...b0b1675. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 5, 2019

Codecov Report

Merging #666 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #666      +/-   ##
==========================================
- Coverage   60.09%   60.06%   -0.04%     
==========================================
  Files         132      132              
  Lines       12561    12561              
==========================================
- Hits         7549     7545       -4     
- Misses       3972     3975       +3     
- Partials     1040     1041       +1
Impacted Files Coverage Δ
db/trie/branchnode.go 65.59% <0%> (-1.61%) ⬇️
consensus/scheme/rolldpos/rolldposctx.go 75.11% <0%> (-0.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d458de5...19a90fe. Read the comment docs.

@yutongp yutongp merged commit 6f31a55 into master Mar 5, 2019
@yutongp yutongp deleted the yutongp-patch-1 branch March 5, 2019 01:43
zjshen14 pushed a commit that referenced this pull request Mar 5, 2019
* Update CONTRIBUTING.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants