Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Gopkg.toml and update dependencies #662

Merged
merged 2 commits into from
Mar 5, 2019

Conversation

CoderZhi
Copy link
Collaborator

@CoderZhi CoderZhi commented Mar 4, 2019

Fix a bug in iotex-election, and update the revision number correspondingly.
dep ensure -update github.com/iotexproject/iotex-election
somehow iotexproject/go-ethereum get updated as well.
All db files should be deleted with this pr.

Test plan: make test & make minicluster

@CoderZhi CoderZhi requested a review from a team as a code owner March 4, 2019 19:39
@codecov
Copy link

codecov bot commented Mar 5, 2019

Codecov Report

Merging #662 into master will increase coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #662      +/-   ##
==========================================
+ Coverage   60.06%   60.34%   +0.28%     
==========================================
  Files         132      135       +3     
  Lines       12561    12920     +359     
==========================================
+ Hits         7545     7797     +252     
- Misses       3974     4046      +72     
- Partials     1042     1077      +35
Impacted Files Coverage Δ
pkg/keypair/keypair.go 65.21% <0%> (-8.98%) ⬇️
blockchain/blockchain.go 49.55% <0%> (-0.07%) ⬇️
crypto/bls.go 61.18% <0%> (ø)
crypto/dkg.go 81.03% <0%> (ø)
crypto/ec160.go 71.15% <0%> (ø)
pkg/keypair/secp256k1.go 90.9% <0%> (+7.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 613ec83...1500e3e. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Mar 5, 2019

Codecov Report

Merging #662 into master will increase coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #662      +/-   ##
==========================================
+ Coverage   60.06%   60.34%   +0.28%     
==========================================
  Files         132      135       +3     
  Lines       12561    12920     +359     
==========================================
+ Hits         7545     7797     +252     
- Misses       3974     4046      +72     
- Partials     1042     1077      +35
Impacted Files Coverage Δ
pkg/keypair/keypair.go 65.21% <0%> (-8.98%) ⬇️
blockchain/blockchain.go 49.55% <0%> (-0.07%) ⬇️
crypto/bls.go 61.18% <0%> (ø)
crypto/dkg.go 81.03% <0%> (ø)
crypto/ec160.go 71.15% <0%> (ø)
pkg/keypair/secp256k1.go 90.9% <0%> (+7.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 613ec83...1500e3e. Read the comment docs.

@raullenchai raullenchai merged commit d458de5 into iotexproject:master Mar 5, 2019
@CoderZhi CoderZhi deleted the update_election_package branch April 25, 2019 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants