-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[consensus] Continuously as Proposer in N rounds #4569
Open
envestcc
wants to merge
4
commits into
iotexproject:master
Choose a base branch
from
envestcc:proposer
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+38
−3
Open
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -54,6 +54,7 @@ func defaultConfig() Genesis { | |
NumCandidateDelegates: 36, | ||
TimeBasedRotation: false, | ||
MinBlocksForBlobRetention: 345600, | ||
WakeNumProposalBatchSize: 5, | ||
PacificBlockHeight: 432001, | ||
AleutianBlockHeight: 864001, | ||
BeringBlockHeight: 1512001, | ||
|
@@ -79,6 +80,7 @@ func defaultConfig() Genesis { | |
TsunamiBlockHeight: 29275561, | ||
UpernavikBlockHeight: 31174201, | ||
VanuatuBlockHeight: 33730921, | ||
WakeBlockHeight: math.MaxUint64, | ||
ToBeEnabledBlockHeight: math.MaxUint64, | ||
}, | ||
Account: Account{ | ||
|
@@ -186,6 +188,8 @@ type ( | |
TimeBasedRotation bool `yaml:"timeBasedRotation"` | ||
// MinBlocksForBlobRetention is the minimum number of blocks for blob retention | ||
MinBlocksForBlobRetention uint64 `yaml:"minBlocksForBlobRetention"` | ||
// WakeNumProposalBatchSize is the number of proposals in a batch | ||
WakeNumProposalBatchSize uint64 `yaml:"numProposalBatchSize"` | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
// PacificBlockHeight is the start height of using the logic of Pacific version | ||
// TODO: PacificBlockHeight is not added into protobuf definition for backward compatibility | ||
PacificBlockHeight uint64 `yaml:"pacificHeight"` | ||
|
@@ -276,6 +280,9 @@ type ( | |
// 1. enable Cancun EVM | ||
// 2. enable dynamic fee tx | ||
VanuatuBlockHeight uint64 `yaml:"vanuatuHeight"` | ||
// WakeBlockHeight is the start height to | ||
// 1. enable 3s block interval | ||
WakeBlockHeight uint64 `yaml:"wakeHeight"` | ||
// ToBeEnabledBlockHeight is a fake height that acts as a gating factor for WIP features | ||
// upon next release, change IsToBeEnabled() to IsNextHeight() for features to be released | ||
ToBeEnabledBlockHeight uint64 `yaml:"toBeEnabledHeight"` | ||
|
@@ -641,6 +648,11 @@ func (g *Blockchain) IsVanuatu(height uint64) bool { | |
return g.isPost(g.VanuatuBlockHeight, height) | ||
} | ||
|
||
// IsWake checks whether height is equal to or larger than wake height | ||
func (g *Blockchain) IsWake(height uint64) bool { | ||
return g.isPost(g.WakeBlockHeight, height) | ||
} | ||
|
||
// IsToBeEnabled checks whether height is equal to or larger than toBeEnabled height | ||
func (g *Blockchain) IsToBeEnabled(height uint64) bool { | ||
return g.isPost(g.ToBeEnabledBlockHeight, height) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete