[statedb] store account by erigon #4559
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
envestcc
requested review from
CoderZhi,
dustinxie,
Liuhaai and
a team
as code owners
|
CoderZhi
reviewed
Mar 5, 2025
Comment on lines
+155
to
+159
| err := store.tx.Commit() | ||
| if err != nil { | ||
| return err | ||
| } | ||
| return nil |
Comment on lines
+95
to
+100
| func WithBlockTimeGetter(getBlockTime func(uint64) (time.Time, error)) StateDBOption { | ||
| return func(sdb *stateDB, cfg *Config) error { | ||
| cfg.getBlockTime = getBlockTime | ||
| return nil | ||
| } | ||
| } |
There was a problem hiding this comment.
Could we delete it and always set getBlockTime? Is this part of the Config or part of the StateDB?
Comment on lines
+493
to
+497
| if sdb.erigonDB != nil { | ||
| ws, err = sdb.newWorkingSetWithErigonOutput(ctx, 0) | ||
| } else { | ||
| ws, err = sdb.newWorkingSet(ctx, 0) | ||
| } |
Comment on lines
+201
to
+223
| // func (store *stateDBWorkingSetStoreWithErigonDryrun) WriteView(name string, value interface{}) error { | ||
| // return store.outer.WriteView(name, value) | ||
| // } | ||
|
|
||
| // func (store *stateDBWorkingSetStoreWithErigonDryrun) Put(ns string, key []byte, value []byte) error { | ||
| // return store.outer.Put(ns, key, value) | ||
| // } | ||
|
|
||
| // func (store *stateDBWorkingSetStoreWithErigonDryrun) Delete(ns string, key []byte) error { | ||
| // return store.outer.Delete(ns, key) | ||
| // } | ||
|
|
||
| // func (store *stateDBWorkingSetStoreWithErigonDryrun) Snapshot() int { | ||
| // return store.outer.Snapshot() | ||
| // } | ||
|
|
||
| // func (store *stateDBWorkingSetStoreWithErigonDryrun) RevertSnapshot(sn int) error { | ||
| // return store.outer.RevertSnapshot(sn) | ||
| // } | ||
|
|
||
| // func (store *stateDBWorkingSetStoreWithErigonDryrun) ResetSnapshots() { | ||
| // store.outer.ResetSnapshots() | ||
| // } |
| } | ||
|
|
||
| func (store *stateDBWorkingSetStoreWithErigonOutput) RevertSnapshot(sn int) error { | ||
| store.store.RevertSnapshot(sn) |
There was a problem hiding this comment.
the error of RevertSnapshot is not handled
Comment on lines
+121
to
+122
| } else { | ||
| panic(fmt.Sprintf("no isn for sn %d", sn)) |
There was a problem hiding this comment.
should we return error or panic?
Comment on lines
+104
to
+111
| blkCtx := protocol.MustGetBlockCtx(ctx) | ||
| g := genesis.MustExtractGenesisContext(ctx) | ||
| chainCfg, err := evm.NewChainConfig(g.Blockchain, blkCtx.BlockHeight, protocol.MustGetBlockchainCtx(ctx).EvmNetworkID, store.getBlockTime) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| chainRules := chainCfg.Rules(big.NewInt(int64(blkCtx.BlockHeight)), g.IsSumatra(blkCtx.BlockHeight), uint64(blkCtx.BlockTimeStamp.Unix())) | ||
| rules := evm.NewErigonRules(&chainRules) |
There was a problem hiding this comment.
Do we need to recreate rules for every tx?
Comment on lines
+145
to
+148
| err = tx.Put(systemNS, heightKey, uint256.NewInt(height).Bytes()) | ||
| if err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
return tx.Put(systemNS, heightKey, uint256.NewInt(height).Bytes())
Comment on lines
+138
to
+141
| err = c.WriteHistory() | ||
| if err != nil { | ||
| return err | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
based #4551
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: