Recover from action handling panic #4513
Open
+21
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
envestcc
requested review from
CoderZhi,
dustinxie and
Liuhaai
as code owners
envestcc
changed the title
dustinxie
reviewed
Dec 6, 2024
dustinxie
approved these changes
Dec 6, 2024
CoderZhi
requested changes
Dec 6, 2024
envestcc
commented
Dec 10, 2024
| ap.DeleteAction(caller) | ||
| actionIterator.PopAccount() | ||
| continue | ||
| case action.ErrPanicButReverted: |
There was a problem hiding this comment.
if panic but reverted, continue when mint and terminate when validate block
envestcc
commented
Dec 10, 2024
| sn := ws.Snapshot() | ||
| defer func() { | ||
| if err != nil { | ||
| if e := ws.Revert(sn); e != nil { |
There was a problem hiding this comment.
Not sure if the Revert() will be a hard fork here. We may need run fullsync
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Capture exceptions when processing transactions to prevent the program from exiting abnormally, and instead remove problematic transactions.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: