[api] Fix not reject unprotected && unwhitelisted action #4510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
envestcc
requested review from
CoderZhi,
dustinxie and
Liuhaai
as code owners
envestcc
changed the title
envestcc
changed the title
envestcc
commented
Dec 3, 2024
| @@ -194,7 +194,7 @@ func (ws *workingSet) runAction( | |||
| } | |||
| // for replay tx, check against deployer whitelist | |||
| g := genesis.MustExtractGenesisContext(ctx) | |||
| if selp.Encoding() == uint32(iotextypes.Encoding_ETHEREUM_UNPROTECTED) && !g.IsDeployerWhitelisted(selp.SenderAddress()) { | |||
| if !selp.Protected() && !g.IsDeployerWhitelisted(selp.SenderAddress()) { | |||
There was a problem hiding this comment.
The behavior has not actually changed because the encoding here will not be the Encoding_TX_CONTAINER, so a hardfork is not needed.
CoderZhi
approved these changes
Dec 3, 2024
|
dustinxie
approved these changes
Dec 3, 2024
dustinxie
pushed a commit
that referenced
this pull request
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This issue did not trigger any invalid actions to be included in the block, so it only needs to be fixed at the API level.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: