Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ioctl][ws][#5] project device sub commands to support interaction with ws contracts #4283

Merged
merged 8 commits into from
May 30, 2024
Merged

[ioctl][ws][#5] project device sub commands to support interaction with ws contracts #4283

merged 8 commits into from
May 30, 2024

Conversation

saitofun
Copy link
Contributor

Description

ioctl support interactions to binding/unbinding device to ws project

supported command

  1. approve device to project ioctl ws device approve
  2. unapprove device from project ioctl ws device unapprove
  3. query if device is approved to project ioctl ws device approved

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • make test

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@saitofun saitofun changed the title [ioctl][ws][#4] project device sub commands to support interaction with ws contracts [ioctl][ws][#5] project device sub commands to support interaction with ws contracts May 29, 2024
@ququzone
Copy link
Contributor

@saitofun need resolve conflicts

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
10.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@saitofun saitofun merged commit b1e286c into master May 30, 2024
2 of 3 checks passed
@saitofun saitofun deleted the feat/ws_project_device_sub_command branch May 30, 2024 07:23
dustinxie pushed a commit that referenced this pull request May 30, 2024
@saitofun @CoderZhi @dustinxie
[ioctl][ws][#5] project device sub commands to support interaction wi…
9245f0a 
…th ws contracts (#4283)


* feat(ioctl/ws): ioctl support ws project device contract interactions

---------

Co-authored-by: CoderZhi <[email protected]>
@BrewTestBot BrewTestBot mentioned this pull request May 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@envestcc envestcc envestcc approved these changes

@huangzhiran huangzhiran huangzhiran approved these changes

@ququzone ququzone ququzone approved these changes

@CoderZhi CoderZhi Awaiting requested review from CoderZhi CoderZhi is a code owner

@dustinxie dustinxie Awaiting requested review from dustinxie dustinxie is a code owner

@Liuhaai Liuhaai Awaiting requested review from Liuhaai Liuhaai is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@saitofun @ququzone @huangzhiran @envestcc @CoderZhi