[ioctl][ws][#3] project sub command to support interaction with ws contracts #4281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saitofun
requested review from
CoderZhi,
dustinxie,
Liuhaai and
envestcc
as code owners
envestcc
reviewed
May 29, 2024
| if err != nil { | ||
| return nil, errors.Wrap(err, "failed to create contract caller") | ||
| } | ||
| caller.SetAmount(big.NewInt(int64(transferAmount.Value().(uint64)))) |
There was a problem hiding this comment.
uint64 is not enough for token amount in rau unit, which can only represent around 18 IOTX at most
envestcc
reviewed
May 29, 2024
ioctl/cmd/ws/wsutil.go
Outdated
There was a problem hiding this comment.
Is it redundent with generated Go like contracts/fleetmanagement.go?
envestcc
approved these changes
May 29, 2024
…/ws_project_sub_command
|
huangzhiran
approved these changes
May 29, 2024
dustinxie
pushed a commit
that referenced
this pull request
May 30, 2024
…ntracts (#4281) * feat(ioctl/ws): ioctl support ws project contracts interactions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
updated reference:
wsutil: impls a universal contract calling with result retrieve and contract reading
supported commands:
ioctl ws project registerioctl ws project attributes set/gegioctl ws project updateioctl ws project queryioctl ws project pause/resumeType of change
How Has This Been Tested?
Test Configuration:
Checklist: