-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[staking] implement staking abi v3 #4273
Conversation
TODO: enable v3 in builder after #4272 was merged |
stakingComm "github.com/iotexproject/iotex-core/action/protocol/staking/ethabi/common" | ||
) | ||
|
||
func BuildReadStateRequest(data []byte) (protocol.StateContext, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BuildReadStateContext
is a better name?
also seems this func only used in test code in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is used at next commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change the name? it's returning different new contexts
Quality Gate failedFailed conditions |
Description
This update upgraded the staking ABI to v3, adding endorsement information when querying buckets.
It's based on #4272
Fixes #(issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: