[api] readState support to non-rolldpos mode #4247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
envestcc
requested review from
CoderZhi,
dustinxie,
Liuhaai and
millken
as code owners
dustinxie
reviewed
Apr 24, 2024
| inputEpochNum := rp.GetEpochNum(inputHeight) | ||
| if inputEpochNum < tipEpochNum { | ||
| rp := rolldpos.FindProtocol(core.registry) | ||
| if rp != nil { |
There was a problem hiding this comment.
what if rp == nil, still cannot read?
There was a problem hiding this comment.
it will go to L949 / L957 to read
dustinxie
reviewed
Apr 24, 2024
api/coreservice.go
Outdated
| rp := rolldpos.FindProtocol(core.registry) | ||
| if rp != nil { | ||
| tipEpochNum := rp.GetEpochNum(tipHeight) | ||
| if height != "" { |
There was a problem hiding this comment.
no need, L932 already checked
Liuhaai
approved these changes
Apr 25, 2024
| tipEpochNum := rp.GetEpochNum(tipHeight) | ||
| inputEpochNum := rp.GetEpochNum(inputHeight) | ||
| if inputEpochNum < tipEpochNum { | ||
| inputHeight = rp.GetEpochHeight(inputEpochNum) |
There was a problem hiding this comment.
can't understand why the height of state is changed in rp, but the changes are acceptable for me compared to the prev
CoderZhi
approved these changes
Apr 30, 2024
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4247 +/- ##
==========================================
- Coverage 77.02% 76.97% -0.05%
==========================================
Files 342 343 +1
Lines 29406 29438 +32
==========================================
+ Hits 22651 22661 +10
- Misses 5650 5670 +20
- Partials 1105 1107 +2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
STANDALONEandNOOPis easy to use thanROLLDPOSin writing e2etest, andreadStateis used to checking things in testing. But it's only supported in ROLLDPOS.Fixes #(issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: