-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[blockdao] Fix program unstopable when blockdao is checking indexer #4217
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4217 +/- ##
==========================================
+ Coverage 75.38% 76.76% +1.37%
==========================================
Files 303 340 +37
Lines 25923 29273 +3350
==========================================
+ Hits 19541 22470 +2929
- Misses 5360 5698 +338
- Partials 1022 1105 +83 ☔ View full report in Codecov by Sentry. |
blockchain/blockdao/blockindexer.go
Outdated
@@ -82,6 +82,12 @@ func (bic *BlockIndexerChecker) CheckIndexer(ctx context.Context, indexer BlockI | |||
} | |||
} | |||
for i := startHeight; i <= targetHeight; i++ { | |||
// ternimate if context is done | |||
select { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if ctx.Err() != nil {
return err
}
balabla
Quality Gate failedFailed conditions |
Description
Fixes #4158
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: