Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[genesis] raise block gas limit to 50M #4181

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

dustinxie
Copy link
Member

Description

as title.

Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Code refactor or improvement
  • [] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
  • [] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • make test
  • [] fullsync
  • [] Other test (please specify)

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • [] My code follows the style guidelines of this project
  • [] I have performed a self-review of my code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes
  • [] Any dependent changes have been merged and published in downstream modules

@dustinxie dustinxie requested review from CoderZhi, Liuhaai, envestcc, millken and a team as code owners March 13, 2024 00:58
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 69.04762% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 76.12%. Comparing base (e1f0636) to head (0338474).
Report is 201 commits behind head on master.

Files Patch % Lines
api/coreservice.go 66.66% 6 Missing ⚠️
action/protocol/poll/consortium.go 0.00% 2 Missing ⚠️
action/protocol/poll/staking_committee.go 0.00% 2 Missing ⚠️
blockchain/blockchain.go 0.00% 2 Missing ⚠️
action/protocol/execution/evm/evm.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4181      +/-   ##
==========================================
+ Coverage   75.38%   76.12%   +0.74%     
==========================================
  Files         303      340      +37     
  Lines       25923    29168    +3245     
==========================================
+ Hits        19541    22205    +2664     
- Misses       5360     5857     +497     
- Partials     1022     1106      +84     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -161,6 +162,8 @@ type (
Timestamp int64
// BlockGasLimit is the total gas limit could be consumed in a block
BlockGasLimit uint64 `yaml:"blockGasLimit"`
// BlockGasLimitBoost is the boosted block gas limit (raised to 50M by default)
BlockGasLimitBoost uint64 `yaml:"blockGasLimitBoost"`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure about the naming and place

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated to better name

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
5.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@dustinxie dustinxie merged commit ba264c2 into iotexproject:master Mar 14, 2024
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants