Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add p2p MaxMessageSize config #4071

Merged
merged 6 commits into from
Jan 30, 2024
Merged

Add p2p MaxMessageSize config #4071

merged 6 commits into from
Jan 30, 2024

Conversation

millken
Copy link
Contributor

@millken millken commented Jan 26, 2024

Description

When MintNewBlock size is bigger, the p2p maxmessagesize limit will be triggered, causing the chain to get stuck.
The default in the original libp2p is 1M, but the default is 12M now.

Fixes #4069

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Code refactor or improvement
  • [] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
  • [] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • test passed on nightly
  • [] fullsync
  • [] Other test (please specify)

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • [] My code follows the style guidelines of this project
  • [] I have performed a self-review of my code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes
  • [] Any dependent changes have been merged and published in downstream modules

@millken millken requested a review from a team as a code owner January 26, 2024 09:14
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Attention: 541 lines in your changes are missing coverage. Please review.

Comparison is base (e1f0636) 75.38% compared to head (7d0a502) 76.20%.
Report is 163 commits behind head on master.

Files Patch % Lines
action/protocol/staking/staking_statereader.go 69.76% 35 Missing and 17 partials ⚠️
action/protocol/execution/evm/evm.go 48.38% 47 Missing and 1 partial ⚠️
api/coreservice.go 63.24% 37 Missing and 6 partials ⚠️
api/web3server.go 79.24% 30 Missing and 3 partials ⚠️
action/candidate_endorsement.go 0.00% 31 Missing ⚠️
action/protocol/staking/protocol.go 36.36% 28 Missing ⚠️
action/candidate_activate.go 0.00% 25 Missing ⚠️
...tion/protocol/staking/contractstake_bucket_type.go 0.00% 24 Missing ⚠️
action/protocol/rewarding/fund.go 23.07% 19 Missing and 1 partial ⚠️
api/websocket.go 0.00% 20 Missing ⚠️
... and 43 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4071      +/-   ##
==========================================
+ Coverage   75.38%   76.20%   +0.82%     
==========================================
  Files         303      338      +35     
  Lines       25923    28807    +2884     
==========================================
+ Hits        19541    21952    +2411     
- Misses       5360     5737     +377     
- Partials     1022     1118      +96     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dustinxie
dustinxie previously approved these changes Jan 26, 2024
@Liuhaai
Copy link
Member

Liuhaai commented Jan 26, 2024

Unconfigurable from iotex core?

@dustinxie
Copy link
Member

Unconfigurable from iotex core?

it has a new API WithMaxMessageSize() which can configure from iotex-core. If not called, it now defaults to 12MB message size.

@dustinxie dustinxie dismissed their stale review January 28, 2024 22:52

other interview comment

@millken
Copy link
Contributor Author

millken commented Jan 29, 2024

Unconfigurable from iotex core?

done

@@ -143,6 +144,7 @@ var DefaultConfig = Config{
EnableRateLimit: true,
PrivateNetworkPSK: "",
MaxPeers: 30,
MaxMessageSize: p2p.DefaultConfig.MaxMessageSize,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the 12MB should be the default parameter for the iotex-core instead of the p2p.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
2.0% Duplication on New Code

See analysis details on SonarCloud

@millken millken merged commit fef8141 into iotexproject:master Jan 30, 2024
4 of 5 checks passed
@millken millken deleted the p2p_maxmessagesize branch January 30, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase p2p max message size to 12M
5 participants