-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add p2p MaxMessageSize config #4071
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4071 +/- ##
==========================================
+ Coverage 75.38% 76.20% +0.82%
==========================================
Files 303 338 +35
Lines 25923 28807 +2884
==========================================
+ Hits 19541 21952 +2411
- Misses 5360 5737 +377
- Partials 1022 1118 +96 ☔ View full report in Codecov by Sentry. |
Unconfigurable from iotex core? |
it has a new API |
done |
@@ -143,6 +144,7 @@ var DefaultConfig = Config{ | |||
EnableRateLimit: true, | |||
PrivateNetworkPSK: "", | |||
MaxPeers: 30, | |||
MaxMessageSize: p2p.DefaultConfig.MaxMessageSize, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the 12MB
should be the default parameter for the iotex-core instead of the p2p.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Description
When MintNewBlock size is bigger, the p2p maxmessagesize limit will be triggered, causing the chain to get stuck.
The default in the original libp2p is
1M
, but the default is12M
now.Fixes #4069
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: