fix ioctl update failed on mac #3957

millken · 2023-11-01T06:21:41Z

Description

The reason why the ioctl update failed on mac is that install-cli.sh requires root privileges to execute.

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
[] New feature (non-breaking change which adds functionality)
[] Code refactor or improvement
[] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
[] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

make test
[] fullsync
[] Other test (please specify)

Test Configuration:

Firmware version:
Hardware:
Toolchain:
SDK:

Checklist:

[] My code follows the style guidelines of this project
[] I have performed a self-review of my code
[] I have commented my code, particularly in hard-to-understand areas
[] I have made corresponding changes to the documentation
[] My changes generate no new warnings
[] I have added tests that prove my fix is effective or that my feature works
[] New and existing unit tests pass locally with my changes
[] Any dependent changes have been merged and published in downstream modules

codecov · 2023-11-01T06:39:44Z

Codecov Report

Attention: 518 lines in your changes are missing coverage. Please review.

Comparison is base (e1f0636) 75.38% compared to head (e0c0d8f) 76.11%.
Report is 112 commits behind head on master.

Files	Patch %	Lines
blockindex/contractstaking/event_handler.go	67.23%	45 Missing and 13 partials ⚠️
action/protocol/staking/staking_statereader.go	69.76%	35 Missing and 17 partials ⚠️
action/protocol/execution/evm/evm.go	44.30%	43 Missing and 1 partial ⚠️
action/protocol/staking/protocol.go	33.33%	28 Missing ⚠️
...tion/protocol/staking/contractstake_bucket_type.go	0.00%	24 Missing ⚠️
api/coreservice.go	67.60%	17 Missing and 6 partials ⚠️
blockindex/contractstaking/util.go	39.47%	22 Missing and 1 partial ⚠️
action/protocol/rewarding/fund.go	23.07%	19 Missing and 1 partial ⚠️
api/websocket.go	0.00%	20 Missing ⚠️
action/protocol/execution/evm/evmstatedbadapter.go	0.00%	19 Missing ⚠️
... and 30 more

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3957      +/-   ##
==========================================
+ Coverage   75.38%   76.11%   +0.73%     
==========================================
  Files         303      330      +27     
  Lines       25923    28160    +2237     
==========================================
+ Hits        19541    21435    +1894     
- Misses       5360     5621     +261     
- Partials     1022     1104      +82

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dustinxie · 2023-11-15T01:45:08Z

install-cli.sh

@@ -122,27 +122,20 @@ else
 fi

 if [ "${OS}" = "darwin" ];then
-    if test -x "$(command -v brew)"; then
+    if test -x "$(command -v brew)"; then      
