Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the config for the detecting of private-key in process of git pre… #3847

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

edwardTianY
Copy link
Contributor

Description

add the config of the detecting of private-key for the git pre-commit hook, in order to user this to scan the private-key, please use the following command:
cd iotex-core
pip install pre-commit

Fixes #(issue)
None

Type of change

Please delete options that are not relevant.

  • [] Code refactor or improvement

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [] after installed this into the git hook
  • [] we can try to submit code, then it should work.

Checklist:

  • [] My code follows the style guidelines of this project
  • [] I have performed a self-review of my code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes
  • [] Any dependent changes have been merged and published in downstream modules

@edwardTianY edwardTianY requested a review from a team as a code owner April 17, 2023 03:27
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Edward Tian seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link

Starting review process for this pull request send by **Edward**
**Commits** in this pull request: 1

**Additions**: 6
**Changed** files: 1
**Deletions**: 0

@edwardTianY edwardTianY self-assigned this Apr 17, 2023
@github-actions
Copy link

ChatGPT's review about .pre-commit-config.yaml file:
This is not Go code, it appears to be a YAML configuration file for the pre-commit tool. As such, there are no potential bugs or code smells to review. However, it is important to ensure that the specified versions of the hooks are compatible with the version of pre-commit being used. Additionally, it may be beneficial to regularly update the versions of the hooks to ensure the latest security vulnerabilities are being checked for.

@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Merging #3847 (fbf8812) into master (e1f0636) will increase coverage by 0.09%.
The diff coverage is 71.09%.

❗ Current head fbf8812 differs from pull request most recent head 59b8d5d. Consider uploading reports for the commit 59b8d5d to get more accurate results

@@            Coverage Diff             @@
##           master    #3847      +/-   ##
==========================================
+ Coverage   75.38%   75.47%   +0.09%     
==========================================
  Files         303      303              
  Lines       25923    26044     +121     
==========================================
+ Hits        19541    19656     +115     
- Misses       5360     5368       +8     
+ Partials     1022     1020       -2     
Impacted Files Coverage Δ
api/web3server_marshal.go 93.21% <ø> (ø)
api/web3server_utils.go 69.20% <16.66%> (-3.67%) ⬇️
state/factory/factory.go 80.20% <33.33%> (+0.86%) ⬆️
state/factory/statedb.go 81.81% <33.33%> (+1.08%) ⬆️
api/serverV2.go 86.95% <50.00%> (ø)
state/factory/workingset.go 71.42% <68.75%> (ø)
api/web3server.go 81.41% <87.50%> (+2.74%) ⬆️
api/coreservice.go 68.09% <88.23%> (+0.74%) ⬆️
action/protocol/context.go 67.42% <100.00%> (+0.24%) ⬆️
blockchain/genesis/genesis.go 72.36% <100.00%> (ø)

... and 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@edwardTianY edwardTianY merged commit 80320b6 into master Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants